rajewsky-lab / novosparc

BSD 3-Clause "New" or "Revised" License
125 stars 41 forks source link

Reconstruction with Marker Warning #46

Closed Hofphi closed 3 years ago

Hofphi commented 3 years ago

Hello everyone,

first of all I must say that I am very grateful for this awesome package!

Recently, I was running into a non-descriptive warning message when executing my script to do tissue reconstruction with marker genes. The script finishes and produces my desired output which looks like I expected.

However, I wanted to report this warning since I am not sure what it means and if it somehow influences my results.

The following reconstruction step produces the warning message:

tissue_with_markers.reconstruct(alpha_linear=0.5)

Warning message that points to a site-package:

Reconstructing spatial information with 3 markers: 828 cells and 500 locations ... 
~/miniconda3/lib/python3.6/site-packages/ot/bregman.py:363: RuntimeWarning: overflow encountered in true_divide
v = np.divide(b, KtransposeU)

Warning: numerical errors at iteration 9
It.  |Err         
-------------------
    0|8.868000e-03|
Warning: numerical errors at iteration 18
Warning: numerical errors at iteration 21
Warning: numerical errors at iteration 18
Warning: numerical errors at iteration 16
Warning: numerical errors at iteration 15
Warning: numerical errors at iteration 15
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
Warning: numerical errors at iteration 14
MalteMederacke commented 3 years ago

I guess, you try to devide something with 0? How does DGE matrix look like

nukappa commented 3 years ago

Hi @Hofphi thank you for the kind words and reporting the warning. We sometimes get these warnings due to sparse DGEs as @MalteMederacke mentioned. A quick remedy is to try with larger values of the epsilon parameter: 10e-3 or 10e-2 and so on, though this might find a suboptimal spatial reconstruction.