search

rajewsky-lab / polyA

0 stars 1 forks source link

cast coordinates to integers #60

Open nukappa opened 8 years ago

nukappa commented 8 years ago

probably in the merge_pAi function, some numbers have to be cast into integers

nukappa commented 8 years ago

looks fine, was probably a matter of different annotation versions. a unit test has to be written to show that everything works ok.

mschilli87 commented 8 years ago

It seems there might still be a bug here: https://github.com/rajewsky-lab/polyA/pull/64#issuecomment-226223033

mschilli87 commented 8 years ago

Once https://github.com/rajewsky-lab/polyA/pull/72/commits/021f7ec694bde85f079d90796888206348d6b8b9 is merged to master, I'll merge it into new_tests to see if this issue is finally resolved.

nukappa commented 8 years ago

ok cool. I will test and merge #72 now. related to the current issue, in one of your next pushes you can also improve the code in the merge_pAi_and_utr_intervals function: cast all start_position and end_position to integers: int(start_position). I wouldn't open a new pull request just for that. For now, even if it compares strings, i think it's doing it fine...

mschilli87 commented 8 years ago

I'll changed this issue's title & labels so we won't forget about that.