search

rajgoesout / poirot

:mag: Asynchronously find usernames across social networks
GNU General Public License v3.0
8 stars 1 forks source link

creating the .txt file should be an option #7

Closed cdrani closed 5 years ago

cdrani commented 5 years ago

Right now a .txt file is created regardless of if you want it or not. Some users might not want that considering that the data displayed on the terminal is the same as that in the file. If users want the file they should indicate it by the use of a flag or something.

rajgoesout commented 5 years ago

@cdrani Would you like to work on this issue?

cdrani commented 5 years ago

Sure. This is reliant on #8 fix. Will apply that fix here as well. Also noticed that you don't actually make use of yargs package here at all. In the fix for this issue I plan on just using the arg values from process. Were you planning on making use of it for more than just the help and version options?

rajgoesout commented 5 years ago

Yes, we can use yargs package for solving this issue

cdrani commented 5 years ago

I am saying that since you are not actually using yargs other than for --help and --version, then perhaps you can remove it and just implement those options.

rajgoesout commented 5 years ago

I'm planning to add more command line arguments/features. That's why I've kept it.

cdrani commented 5 years ago

Ok. Will keep.