codepathreview
commented
8 years ago Nice work finishing all required stories. Please consider adding optionals as you will get to learn more while implementing them.
A few notes after checking out the code:
- Properly used spinners (with populated values) to allow users to select filters
- Consider moving the search field into the ActionBar using a custom ActionBar layout or with a SearchView
- Consider using the ViewHolder pattern to improve performance of photos
ListView. - Consider adding ShareIntent
- Consider using Parcelable instead of Serializable (benefits)
- Consider adding progress bars to your app whenever a network request goes out
Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
My app is complete - please review. /cc @codepathreview @codepath https://github.com/rajivbammi/Android/tree/master/GridImageSearch