rajivranjanmars / readme

Create your GitHub profile Readme.md file
https://rajivranjanmars.github.io/readme/
17 stars 20 forks source link

The Linked in badge doesn't render well #13

Closed nworiekingslee closed 2 years ago

nworiekingslee commented 2 years ago

Screenshot (322)

nworiekingslee commented 2 years ago

I will go ahead to fix this issue

nworiekingslee commented 2 years ago

I noticed it breaks when there's a special character like '-' in the username. I also tried other special characters to see if it affects the md generated. Other symbols allowed like ".", "_" for username doesn't break the generated md

LinkedIn allows "-" in its username, mine for example. I added a statement to check out for the symbol and eliminate it.

nworiekingslee commented 2 years ago

Old code

const linkedinUsername = document.getElementById('linkedinUsername').value, ...

My modification

const linkedinUsername = document.getElementById('linkedinUsername').value.replace("-", ""), ...

nworiekingslee commented 2 years ago

While at it, I corrected a misspelling I noticed in the generated md

Old code

Hi ,I Am ${nameOfUser}! ...

My modification

Hi ,I am ${nameOfUser}! ..

nworiekingslee commented 2 years ago

@rajivranjanmars I made a PR-(https://github.com/rajivranjanmars/readme/pull/14)

nworiekingslee commented 2 years ago

Sweeet! I will go ahead to close this issue.