rajivranjanmars / readme

Create your GitHub profile Readme.md file
https://rajivranjanmars.github.io/readme/
17 stars 20 forks source link

Improvements (1/2) #7

Closed Daksh777 closed 3 years ago

Daksh777 commented 3 years ago

Changes:

I'll create another PR for some more improvements so please don't close #6

netlify[bot] commented 3 years ago

✔️ Deploy Preview for serene-joliot-85a1e8 ready!

🔨 Explore the source changes: 6c051b7a01a878fd2c053e63a62be0676781b951

🔍 Inspect the deploy log: https://app.netlify.com/sites/serene-joliot-85a1e8/deploys/615d19bbe0fe770007e0a281

😎 Browse the preview: https://deploy-preview-7--serene-joliot-85a1e8.netlify.app/

Daksh777 commented 3 years ago

Hey @rajivranjanmars, can you check the PR?

rajivranjanmars commented 3 years ago

Can you specify, exactly what is the purpose of using jquery here, because it is failing the checks by Github? I am trying to resolve the error from my end, I will accept it if I can resolve it by myself.

rajivranjanmars commented 3 years ago

Give me some time. Meanwhile, I am looking forward to your next PR also it will be so thankful if you resolve it from your end.

Daksh777 commented 3 years ago

Can you specify, exactly what is the purpose of using jquery here, because it is failing the checks by Github? I am trying to resolve the error from my end, I will accept it if I can resolve it by myself.

What do you mean? jQuery has been present in your index.html file since the beginning and I did not add it https://github.com/rajivranjanmars/readme/blob/938f84d68d5505c1d7870c4f9c2dd3f3b52f1f2f/index.html#L14-L16

The failing check is because the jQuery is being served from an HTTP connection instead of an HTTPS one. I'll add the HTTPS jQuery CDN and it should resolve

Daksh777 commented 3 years ago

As you can see, the checks are passed now. You can merge it @rajivranjanmars