reviewState in participant-state-changed-feed-event.js is incorrect

rajivrnair / upsource-slack-api-adapter

Simple adapter to transform Upsource's webhook to Slack's format.

Do What The F*ck You Want To Public License

13 stars 12 forks source link

Open KOConchobhair opened 7 years ago

KOConchobhair commented 7 years ago

reviewState in the participant-state-changed-feed-event.js is incorrect.

According to the upsource API docs, ParticipantStateChangedFeedEventBean has a ParticipantState which is defined as follows:

Name    Number  Description
Unread    0 
Read    1   
Accepted    2   
Rejected    3

rocketraman commented 7 years ago

I'm pretty sure this is resulting in messages like the following when a review is "Accepted" by a reviewer:

Participant state changed from _Closed_ to undefined

Obviously, it would be nice if it said something like:

<Reviewer name> accepted review

rocketraman commented 7 years ago

This should be fixed now.