List grf issues and bugfixes to be reflected here - Githubissues

rajkumarkarthik / mgrf-develop

Working version of multivariate generalized random forests

GNU General Public License v3.0

3 stars 1 forks source link

List grf issues and bugfixes to be reflected here #2

Open halflearned opened 5 years ago

halflearned commented 5 years ago

The following issues and bugfixes were solved in the grf repo after mgrf forked it. (Not yet a complete list)

[ ] #362 Remove the purity condition on outcomes during splitting
[ ] #331 Fix a bug in causal forest tuning where imbalance.penalty was being cast to a bool Note: imbalance.penalty is still called lambda in mgrf
[ ] #329 Allow for a factor as a cluster variable
[ ] #294 Fixing zero-index observations in get_tree
[ ] #259 RandomSampler::draw now uses Fisher-Yates algorithm

In addition to the above, the following functionality is missing from mgrf:

[ ] Computing a debiased estimate of the MSE for oob predictions This starts with PR #184, but subsequent PRs have also implemented several important bugfixes
[ ] Instrumental forests have a dedicated splitting strategy Implementation here
[ ] Computing the average treatment and partial effects ATE: here, APE: here

KipchumbaE commented 4 years ago

I tried to install mgrf using the R link provided. I already installed ‘grf’ version 1.2.0 but does not include multivariate treatments. I get the following error: Error in download.file(p, destfile, method, mode = "wb", ...) : cannot open URL 'https://raw.github.com/rajkumarkartik/mgrf-develop/master/releases/grf_0.9.3.tar.gz'