search

rajlaud / pysqueezebox

Python interface to Logitech Media Server for Home Assistant Squeezebox integration
Apache License 2.0
15 stars 5 forks source link

setup.py: add install dependency #2

Closed nyanloutre closed 4 years ago

nyanloutre commented 4 years ago

Hello,

I am packaging this library for NixOS https://github.com/NixOS/nixpkgs/pull/96689 and I noticed that the aiohttp dependency is not checked by the setup.py This patch is not mandatory for the packaging but I thought it's nice to have this.

Also the tests are missing in the sdist package from pypi, is this intentional ?

rajlaud commented 4 years ago

Thanks! Good catch. I suppose the home assistant dependencies were covering for me.

Right now the tests are very much a work in progress, so I haven't included them in any releases.

nyanloutre commented 4 years ago

OK, thanks for the quick answer !