search

rajlaud / pysqueezebox

Python interface to Logitech Media Server for Home Assistant Squeezebox integration
Apache License 2.0
15 stars 5 forks source link

0.9.x break favorites functionality #9

Open peteS-UK opened 2 hours ago

peteS-UK commented 2 hours ago

Hi @rajlaud . The 0.9.x versions of the lib break the favorites functionality that was working in 0.8.1. I just get

2024-09-25 07:49:42.041 DEBUG (MainThread) [homeassistant.components.squeezebox.media_player] Reached async_browse_media with content_type None and content_id None
2024-09-25 07:49:42.042 DEBUG (MainThread) [pysqueezebox.server] URL: http://192.168.3.20:9000/jsonrpc.js Data: {"id": "1", "method": "slim.request", "params": ["", ["favorites", "0", "1"]]}
2024-09-25 07:49:42.059 ERROR (MainThread) [pysqueezebox.server] Failed communicating with LMS(http://192.168.3.20:9000/jsonrpc.js): <class 'aiohttp.client_exceptions.ServerDisconnectedError'>

when I try and list favorites with 0.9.1 or 0.9.2. I'll try and dig later, but wanted to let you know asap. If I just change the manifest from the dev branch back to 0.8.1 (and remove the model stuff from media_player), then it works again, so it looks like something got lost in the version changes.

peteS-UK commented 2 hours ago

I haven't had a chance to look at the lib yet, but shouldn't the query be ["favorites", "items","0", "1"]], not just ["favorites","0", "1"]], although that would only list 1 favorite anyway so I may be misinterpreting.

peteS-UK commented 2 hours ago

Hmm - confused. I can't see any of your favorites functionality in server.py now.