rajnandan1 / kener

Kener is a Modern Self hosted Status Page, batteries included

https://kener.ing/

MIT License

2.5k stars 104 forks source link

Support navigating to the website #45

Closed orhun closed 10 months ago

orhun commented 10 months ago

Is your feature request related to a problem? Please describe.

Currently I use the description field to paste the website address that is being checked:

- name: Website
  description: https://orhun.dev
  tag: website
  image: "https://orhun.dev/img/crow.png"
  api:
    method: GET
    url: https://orhun.dev

Describe the solution you'd like

It would be nice to have a button to open the website in a new tab.

Describe alternatives you've considered None.

Additional context Maybe this is possible somehow but I couldn't find it.

My instance is here: https://status.orhun.dev

rajnandan1 commented 10 months ago

This is already supported. HTML is supported in description. You can use tailwind classes

Example

- name: Website
  description: <a class="font-medium underline underline-offset-4" href="https://orhun.dev" target="_blank">https://orhun.dev</a>
  tag: website
  image: "https://orhun.dev/img/crow.png"
  api:
    method: GET
    url: https://orhun.dev

Sample

https://kener.ing/monitor-frogment

orhun commented 10 months ago

I see, but maybe a built-in feature for adding another button next to the share button for navigating to api.url would be also nice. This would simplify the configuration a lot since I need to add links for each monitor if I want to go with HTML.

What do you think? 🐻

rajnandan1 commented 10 months ago

True

But I feel it is subjective. Some like explicit, some like implicit.

Nevertheless, I can add a link to the end of description if monitors is GET /url if no headers present in the monitor

What do you think?

orhun commented 10 months ago

That sounds reasonable!

rajnandan1 commented 10 months ago

This is done

47

orhun commented 10 months ago

Thank you!

sqkkyzx commented 7 months ago

True

But I feel it is subjective. Some like explicit, some like implicit.

Nevertheless, I can add a link to the end of description if monitors is GET /url if no headers present in the monitor

What do you think?

Does this mean that if I want to hide the URL, I can add any header and then my URL will not appear on the page?

I think this should be reflected in the documentation. The documentation should clearly indicate when it will be explicit and when it will be implicit.