search

rajrakeshdr / pychess

Automatically exported from code.google.com/p/pychess
GNU General Public License v3.0
0 stars 0 forks source link

Put an asterisk in the title bar for games that need saving #257

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Programs like gedit have a small asterisk in the title bar, for games that
need saving.

To implement, GameModel should probably add a needsSaveChanged signal,
which Main would register. GameModel already have a needsSave variable, so
it shouldn't be a problem.
Besisdes adding/removing the asterisk on the signal, Main also needs to
add/remove it, when tab changes.

Original issue reported on code.google.com by lobais on 13 Nov 2007 at 3:34

GoogleCodeExporter commented 9 years ago 
Gedit also put the asterisk in the tabs it seams.

It also puts the filepath in the title bar. I don't think pychess should do this
though. Gedit is more centered around files than pychess.

Original comment by lobais on 13 Nov 2007 at 4:50

GoogleCodeExporter commented 9 years ago

Original comment by lobais on 9 Dec 2007 at 2:38

GoogleCodeExporter commented 9 years ago 
Window title now reflects page title.

Original comment by lobais on 24 Jun 2010 at 12:14

GoogleCodeExporter commented 9 years ago 
I'm a bit sceptical on this, as we are in fact not a text editor.

Original comment by lobais on 24 Jun 2010 at 12:29

GoogleCodeExporter commented 9 years ago

Original comment by mattgatto on 26 Jun 2010 at 12:50

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Fixing

Original comment by G.nius...@gmail.com on 4 Jul 2013 at 2:49

GoogleCodeExporter commented 9 years ago 
Fix'ed https://G.nius.ck@code.google.com/r/gniusck-issue257/ Also, 
GameWidget.name_changed takes an argument that is does not use. Should we take 
action to get rid of the argument, or is it due to polymorphism (there is 
another GameWidget like thing, whose name_change uses its argument) or 
something.

Original comment by G.nius...@gmail.com on 4 Jul 2013 at 11:29

GoogleCodeExporter commented 9 years ago 
Pulled. Thx!

The argument is the object, which triggered the signal. See 
http://www.pygtk.org/docs/pygobject/class-gobject.html#method-gobject--connect

Original comment by gbtami on 5 Jul 2013 at 7:00

GoogleCodeExporter commented 9 years ago 
Ah yes

Original comment by G.nius...@gmail.com on 6 Jul 2013 at 12:40

GoogleCodeExporter commented 9 years ago 
I'm not sure I agree with this change. As Thomas said, a chess game is not like 
an unsaved text document (and the user is given a "save game?" anyway when they 
try to close an unsaved game). Plus, it's confusing when playing FICS games 
because it makes it look like the first player in the tab is an administrator 
(who have "*" next to their names).

Original comment by mattgatto on 7 Jul 2013 at 6:51

GoogleCodeExporter commented 9 years ago

Original comment by mattgatto on 7 Jul 2013 at 6:51

GoogleCodeExporter commented 9 years ago

Original comment by mattgatto on 7 Jul 2013 at 6:51

GoogleCodeExporter commented 9 years ago 
Hmm. The remaining question is: do we want this '*' thing in any form at all? 
If not, I revert this changeset.
Thomas, what do you think?

Original comment by gbtami on 7 Jul 2013 at 8:56

GoogleCodeExporter commented 9 years ago 
FICS names can not have spaces (I believe.) Therefore, if we change it to '* ' 
(w/ a space,) there would be no confusion.

Original comment by G.nius...@gmail.com on 8 Jul 2013 at 2:08

GoogleCodeExporter commented 9 years ago 
You can get the proposal at 
https://G.nius.ck@code.google.com/r/gniusck-issue257/ .

Original comment by G.nius...@gmail.com on 8 Jul 2013 at 5:28

GoogleCodeExporter commented 9 years ago 
I should really not put issue names exactly in the clone names.

Original comment by G.nius...@gmail.com on 8 Jul 2013 at 5:29