rajrakeshdr / pychess

Automatically exported from code.google.com/p/pychess
GNU General Public License v3.0
0 stars 0 forks source link

Parsing error is bad #292

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
When entering a game with bad coordinates, the error dialog is
1) Not user friendly
2) Not hideable by pressing the OK button

Actually it would also be more logical if the same warning dialog would pop
up when loading a pgn with errors.

Original issue reported on code.google.com by lobais on 11 Jan 2008 at 10:45

GoogleCodeExporter commented 9 years ago
Currently the error looks like this:

-----
Problems parsing File

Unable to parse PGN: e4 e5 eg5
at move 3
Gave error: (u"Bad SAN move 'eg5'. No piece is able to move to g5. 4 None Pawn 
0 
available moves: [80, 82, 396, 405, 407, 268, 332, 339, 346, 353, 360, 204, 
213, 222,
231, 528, 593, 658, 723, 853, 918, 983, 536, 601, 666, 731, 861, 926, 991]
rnbqkbnr/pppp1ppp/8/4p3/4P3/8/PPPP1PPP/RNBQKBNR w KQkq e6 0 2",)
-----

This would probably be better:

-----
The game can't be read to end, because no piece can move 3. move - eg5

Enter a different move, or start playing from after move 2 - e5
-----

The pgn loading error would have to look a little different.

Original comment by lobais on 11 Jan 2008 at 11:35

GoogleCodeExporter commented 9 years ago

Original comment by lobais on 14 Jan 2008 at 8:47

GoogleCodeExporter commented 9 years ago
Fixed in 867

Original comment by lobais on 16 Jan 2008 at 2:59