Some icons not provided by gnome-icon-theme

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Run pychess without echo-icon-theme (or any other icon theme that
provides icons modified in patch below)

What is the expected output? What do you see instead?
Should work; pychess claims dependency only on gnome-icon-theme

Note: In some places, pychess is already using an alternate icon set if the
stock_* icons are not found; this just needs to be extended to cover the
places addressed in the patch.

Did you use an installed version of PyChess or did you run in from a
tarball/svn?
Installed

Original issue reported on code.google.com by michel.s...@gmail.com on 27 Aug 2008 at 12:37

Attachments:

• pychess-0.8.2-icons.patch

[GoogleCodeExporter]

The main problem has been, that the stock_weather-storm icons are much nicer to 
look
at, than the weather-storm ones :)
I don't know if it is still the case. I'll take a look.
Thanks for the patch.

Original comment by lobais on 28 Aug 2008 at 11:21

• Changed state: Accepted

[GoogleCodeExporter]

I'd be happy to add an additional dependency to the Fedora package, if you can
document where the stock_ icons are coming from.

As I mentioned earlier, the patch is not ideal -- you might want to do catch the
exception and substitute the icons. Actually, even better: load all the icons 
in one
place, say an "icons" module? that way people who want to customize pychess'
look-and-feel don't have to look at multiple places (well, they still need to 
look at
the Glade files. Updated patch that also fixes fics_logon.glade below).

Is FICS support functional? On my system, after a successful login, the 
interface
stops repainting itself. The only change I've made is to install the pychess 
data in
/usr/share/pychess rather than /usr/share/games/pychess, per Fedora packaging 
guidelines.

Original comment by michel.s...@gmail.com on 28 Aug 2008 at 5:23

Attachments:

• pychess-0.8.2-icons.patch

[GoogleCodeExporter]

Thanks, I'll look into implementing your patch. Also, an icon module sounds
appealing, even though it really shouldn't be nessesary with gtk, tango and all 
that.

The freeze might be fixed in trunk. It shouldn't be affected by install 
location at
least. By the way, why is there a /usr/share/games directory, if games are not
supposed to lie there?

Original comment by lobais on 17 Sep 2008 at 5:40

[GoogleCodeExporter]

Ah, if the Tango icon set is a requirement, and pychess works fine if that's
installed, then we can drop the patch and document the requirement. It's just 
that
it's not installed by default on Fedora, so would be nice to explicitly declare 
the
dependency.

As for /usr/share/games, I have completely no idea why it's still there. 
Presumably a
relic from older file-system layouts -- or perhaps it's just Fedora's filesystem
layout guideline that disallows certain things that are in FHS. They're not too 
happy
about /opt and /srv in RPM packages either.

Original comment by michel.s...@gmail.com on 17 Sep 2008 at 6:19

[GoogleCodeExporter]

If you don't have tango installed, can you test if it works with it? If it 
does, I'll
add a notice somewhere ;)

I'll just change standard directory to /usr/share then. Thanks.

Original comment by lobais on 20 Sep 2008 at 12:57

[GoogleCodeExporter]

I've changed the requested icons. Can you check if there are any new ones 
causing
trouble?

Original comment by lobais on 12 Dec 2008 at 7:06

[GoogleCodeExporter]

Original comment by lobais on 10 Feb 2009 at 7:03

• Changed state: Need-Info

[GoogleCodeExporter]

Original comment by gbtami on 21 Apr 2013 at 7:01

• Changed state: Fixed