search

rajrmen / motech

Automatically exported from code.google.com/p/motech
Other
1 stars 0 forks source link

Uncatchable exception in SMS-HTTP #10

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
In the class SmsSendHandler in the sms-http module, if an incorrect response is 
returned from the HTTP request, the module throws an 
SmsDeliveryFailureException. However, this is uncatchable by implementers and 
is not handled anywhere in the platform or sms-http module. Sms-http listens on 
SEND_SMS events. An implementer calls the service provided by the sms-api 
module, which raises the SEND_SMS event and that is shuttled to a JMS queue 
which is sent back in to the ServerEventRelay, so the implementer is unable to 
access exceptions the http module throws. An alternative would be to raise a 
new event indicating the response was incorrect.

Original issue reported on code.google.com by russell.gillenjr@maine.edu on 1 Feb 2012 at 8:03

GoogleCodeExporter commented 9 years ago

Original comment by russell.gillenjr@maine.edu on 24 Apr 2012 at 3:03

GoogleCodeExporter commented 9 years ago

Original comment by sanchit....@gmail.com on 8 May 2012 at 4:34

GoogleCodeExporter commented 9 years ago 
Moved to Trello

https://trello.com/card/uncatchable-exception-in-sms-http/4f998b99bce6f4507520fb
65/1

Original comment by rlarub...@grameenfoundation.org on 10 May 2012 at 6:46