first-class support for musl platforms

rake-compiler / rake-compiler-dock

Easy to use and reliable cross compiler environment for building Windows, Linux, Mac and JRuby binary gems.

MIT License

77 stars 30 forks source link

first-class support for musl platforms #111

Closed flavorjones closed 9 months ago

flavorjones commented 10 months ago

Approach taken in this PR:

[x] reproduce the issue described in https://github.com/sparklemotion/sqlite3-ruby/issues/434
- failure here
[x] build a cross-compilation (to musl) environment using https://github.com/richfelker/musl-cross-make
[x] test all the musl platforms we want to build
- [x] ad hoc multiarch tests
- [x] x86_64-linux-musl matrix
- [x] x86-linux-musl matrix
- [x] arm-linux-musl matrix
- [x] aarch64-linux-musl matrix
[x] can we update rubygems in CI and get older ruby images to test cleanly?
[x] document minimum rubygems version needed for -gnu or -musl suffixes to be recognized

Closes #75 (or will, once this is complete)

flavorjones commented 9 months ago

@larskanis This is a relatively small but significant change, so I'd love your :eyes: on it. Changes to the Dockerfile template are minimal, essentially adding this file for musl platforms:

build/mk_musl_cross.sh

And the CI is made more thorough.

flavorjones commented 9 months ago

Planning to merge this tomorrow (2024-01-23) so I can start testing downstream using the snapshot images.

larskanis commented 9 months ago

Looks all good! 👍

Your documentation looks like you've seriously checked, that Rubygems is working with linux-gnu vs. linux and that the download of the correct version from rubygems.org works as expected. This is my only concern.

I'd like to try the musl support with ffi.gem, which didn't work there so far. So I'm looking forward to try out a prerelease.

Sorry for having very little time for OSS development. It's hard to work together with me...