Update pkg-config in manylinux build images to 0.29.2

rake-compiler / rake-compiler-dock

Easy to use and reliable cross compiler environment for building Windows, Linux, Mac and JRuby binary gems.

MIT License

78 stars 30 forks source link

Closed flavorjones closed 5 months ago

flavorjones commented 6 months ago

Addresses concerns from #121

Note that:

the original pkg-config is in /usr/bin
this patch installs the new pkg-config into /usr/local/bin
and /usr/local/bin is ahead of /usr/bin in $PATH so the new one should be used by default

If this works, then I'll add some documentation around it.

flavorjones commented 6 months ago

cc @mudge

mudge commented 6 months ago

Thanks, @flavorjones. What’s the best way for me to test this out?

flavorjones commented 5 months ago

Comparing re2's x86_64-linux build on my laptop between the 1.5.0 image and an image generated from this PR's branch ("1.5.1.dev"):

@mudge Objections to me merging this and shipping 1.5.1?

mudge commented 5 months ago

None whatsoever!

flavorjones commented 5 months ago

@mudge Here are the steps I took:

on dev machine, clone this branch, run gem build, and run gem install path/to/rake-compiler-dock-1.5.1.dev.gem
in your re2 working directory, update re2.gemspec to depend on 1.5.1.dev
bundle update and bundle package so that your r-c-d builds can access the gem from vendor/cache

That was it.