search

rake-compiler / rake-compiler-dock

Easy to use and reliable cross compiler environment for building Windows, Linux, Mac and JRuby binary gems.
MIT License
77 stars 30 forks source link

README.md: Update docker-toolbox download URL #27

Closed glebm closed 5 years ago

glebm commented 5 years ago

Docker Toolbox for Windows is no longer available from the Docker Website. Docker Desktop is available instead but it doesn't work with VirtualBox which rake-compiler-dock uses.

larskanis commented 5 years ago

Thank you! I did a try with an old Docker Desktop version but it didn't work on my system. So I usually build on Linux and run the gem on Windows. Nevertheless if docker commands work, then rake-compiler-dock should work too.

glebm commented 5 years ago

Nevertheless if docker commands work, then rake-compiler-dock should work too.

Not with Docker Desktop on Windows. On Windows, Docker Desktop requires Hyper-V (available only in Windows 10 Pro). Hyper-V is not compatible with VirtualBox.

Perhaps we could make it auto-detect and use Hyper-V here:

https://github.com/rake-compiler/rake-compiler-dock/blob/ef4a872ac06dcb295bd4324acdc8f181370ff87c/lib/rake_compiler_dock/docker_check.rb#L87

For now I'm OK with Docker Toolbox though. I do most of my development on Linux, just wanted to make sure that Windows collaborators could use the gem as well.