rake-compiler / rake-compiler-dock

Easy to use and reliable cross compiler environment for building Windows, Linux, Mac and JRuby binary gems.
MIT License
77 stars 30 forks source link

Do not call STDIN.cooked! unless it is a tty #31

Closed casperisfine closed 4 years ago

casperisfine commented 4 years ago

Ref: https://github.com/protocolbuffers/protobuf/pull/7027

We're trying to build google-protocol buffers for Ruby 2.7, but the build is failing with:

Errno::ENOTTY: Inappropriate ioctl for device
/usr/local/rvm/gems/ruby-2.4.1/gems/rake-compiler-dock-1.0.0/lib/rake_compiler_dock/starter.rb:16:in `cooked!'
/usr/local/rvm/gems/ruby-2.4.1/gems/rake-compiler-dock-1.0.0/lib/rake_compiler_dock/starter.rb:16:in `ensure in sh'
/usr/local/rvm/gems/ruby-2.4.1/gems/rake-compiler-dock-1.0.0/lib/rake_compiler_dock/starter.rb:16:in `sh'
/usr/local/rvm/gems/ruby-2.4.1/gems/rake-compiler-dock-1.0.0/lib/rake_compiler_dock.rb:46:in `sh'
/tmpfs/src/github/protobuf/ruby/Rakefile:73:in `block in <top (required)>'
/usr/local/rvm/gems/ruby-2.4.1/gems/rake-13.0.1/exe/rake:27:in `<top (required)>'
/usr/local/rvm/gems/ruby-2.4.1/bin/ruby_executable_hooks:15:in `eval'
/usr/local/rvm/gems/ruby-2.4.1/bin/ruby_executable_hooks:15:in `<main>'

@larskanis

larskanis commented 4 years ago

Oh damn, you're right!

larskanis commented 4 years ago

rake-compiler-dock-1.0.1 is published and should fix this.

casperisfine commented 4 years ago

Thanks a lot for the timely release !