search

rake-compiler / rake-compiler-dock

Easy to use and reliable cross compiler environment for building Windows, Linux, Mac and JRuby binary gems.
MIT License
77 stars 30 forks source link

Use openjdk 11 to make maven work on ubuntu 20.04 #64

Closed Maaarcocr closed 2 years ago

Maaarcocr commented 2 years ago

The current version of maven, which comes with ubuntu 20.04, does not work with jdk 16/17 as per https://bugs.launchpad.net/ubuntu/+source/maven/+bug/1930541

In order to have maven working in the docker container, the only solution I could come up with is to go back to jdk 11, while also maintaining ubuntu:20.04 as the base for the image.

Another solution would be to use 21.10. but that's not LTS. Hopefully the new LTS version of ubuntu won't have this problem, but it's not there yet.

larskanis commented 2 years ago

I'd like to avoid the use of Ubuntu-22.04 before it's released. Could you revert to jdk-11?

Also, would you mind to add a simple test case for maven to this repository? To make sure, we don't break it again. Maybe just extend the JRuby part of rcd_test by some maven usage?

Maaarcocr commented 2 years ago

I'd like to avoid the use of Ubuntu-22.04 before it's released. Could you revert to jdk-11?

Also, would you mind to add a simple test case for maven to this repository? To make sure, we don't break it again. Maybe just extend the JRuby part of rcd_test by some maven usage?

will do!

larskanis commented 2 years ago

Thank you! Merged.

Maaarcocr commented 2 years ago

Thank you! Merged.

Thank you!

Sorry to bother you, do you have a rough idea of when a release with these changes may happen? Just to know if I should just point to main to unblock something else or I should wait. (It's the end of the week anyway, so it does not matter that much, just mostly curious)