fix windows ucrt library filename

rake-compiler / rake-compiler-dock

Easy to use and reliable cross compiler environment for building Windows, Linux, Mac and JRuby binary gems.

MIT License

77 stars 30 forks source link

fix windows ucrt library filename #70

Closed flavorjones closed 2 years ago

flavorjones commented 2 years ago

Fix the DLL naming issue described at https://github.com/rake-compiler/rake-compiler-dock/issues/69 and https://github.com/grpc/grpc/pull/30081

This PR will be three commits, and I'm using CI to provide signal after the second and third:

[x] expand CI coverage to include more versions of Ruby including 3.1 on windows (ucrt)
[x] add tests to build static libraries (these will fail with ucrt)
[x] fix the file names in the Dockerfile

I'll leave it in draft mode until I get to the final commit.

flavorjones commented 2 years ago

Boom, got the failure we wanted: https://github.com/rake-compiler/rake-compiler-dock/runs/7046504346?check_suite_focus=true

flavorjones commented 2 years ago

@larskanis Once this goes green again (after responding to your comment above) and we merge it, would you mind cutting a new patch release for the grpc folks? (I can push the gem, but I don't think I have privileges to push the OCI images to dockerhub.)

larskanis commented 2 years ago

Yes, will do.

larskanis commented 2 years ago

rcd-1.2.2 is uploaded now.

flavorjones commented 2 years ago

Thank you!