search

rake-compiler / rake-compiler-dock

Easy to use and reliable cross compiler environment for building Windows, Linux, Mac and JRuby binary gems.
MIT License
77 stars 30 forks source link

Update `rake-compiler` gem version for images #72

Closed ianks closed 2 years ago

ianks commented 2 years ago

Noticed the Docker images were using an older version of rake-compiler for the default. This patch updates it to use the latest version (~>1.2.0).

flavorjones commented 2 years ago

Thanks for this contribution! I've kicked off CI and we'll see how it looks.

flavorjones commented 2 years ago

@ianks As you can see, this failed because there are other bits in the Dockerfile that are specific to rake-compiler v1.1.6, and note that rake-compiler-dock patches rake-compiler.

I think in order to move this forward, we'll need to take a look at those patches and a) determine if they're still needed in a later version of rake-compiler, and b) if so port them to the new version.

Would you be willing to do a little more work on this? If not, that's OK, but then please close it and we'll get around to it eventually.

ianks commented 2 years ago

@flavorjones I think the patches are still needed. I think my updates should should work properly. Can you give CI another whirl? 🤞🏻

flavorjones commented 2 years ago

Thanks! Kicked CI again, but I believe the patches need to be updated as well (the directory name, and possible the actual diffs as well).