search

rake-compiler / rake-compiler-dock

Easy to use and reliable cross compiler environment for building Windows, Linux, Mac and JRuby binary gems.
MIT License
77 stars 30 forks source link

Provide `linux/arm64` Docker images #79

Closed ianks closed 1 year ago

ianks commented 1 year ago

When using a Macbook M1,rake-compiler-dock images have to run in emulation mode which makes things considerably slower. Docker also spits out a warning about it:

WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

This PR adds a step to the CI matrix which publishes linux/arm64 versions to Docker hub, which will make my CPU much happier :)

resolves #78

ianks commented 1 year ago

Can someone trigger a re-run please? :)

ianks commented 1 year ago

Hmmm, not sure if this error is related to my change set or not, but both amd64 and arm64 are failing on autogen.sh

flavorjones commented 1 year ago

I've opened up #80 to investigate what's going on with the builds. Seems like bitrot.

sodabrew commented 1 year ago

Can rebase this PR following the #81 merge?

ianks commented 1 year ago

~looks like we're blocked by https://github.com/pypa/manylinux/pull/1412 anyway :/~

I was wrong, we should be good now

flavorjones commented 1 year ago

@ianks you may want to rebase again since I just merged https://github.com/rake-compiler/rake-compiler-dock/pull/82

ianks commented 1 year ago

Alright, here's a summary after I let the builds run overnight:

I need to dive in more to debug these, but figured I'd post a summary in case someone can give a helpful pointer. Wouldn't mind rubber fucking this a bit!

flavorjones commented 1 year ago

Damn, I think my refactoring of Dockerfile.mri.erb is going to make you have to resolve some minor conflicts. Sorry for the inconvenience.

flavorjones commented 1 year ago

Also - I was planning on working on https://github.com/rake-compiler/rake-compiler-dock/issues/71 this weekend, which would publish "nightly" images to GHCR. If that meets your needs you may be able to drop the tarball upload step in this PR.

ianks commented 1 year ago

This branch is kind of FUBAR at the moment, and I'm having trouble piecing things together. TBH, I'm not sure about the feasibility of this patch...

flavorjones commented 1 year ago

@ianks OK, don't feel pressured to land this in time for Ruby 3.2 support, we can add it in a 1.3.x patch release when it's ready.