Closed ivoanjo closed 1 year ago
Oh, could you open a PR for this?
Sounds good, I should have a PR for this within the next days! (Travelling a bit right now!)
I submitted PR #226
Could you try 1.2.5?
Yeap, can confirm it works now, thanks for the speedy fix :)
Hello there :wave:!
I work at @datadog on the ddtrace gem. We use the
rake-compiler
gem to build our native extension, and it's extremely useful, thanks for your work on it! :pray:Yesterday our CI started failing after it picked up
rake-compiler
1.2.4 on Ruby 2.5 and below:We've had to pin an older version of
rake-compiler
to work around this.The issue seems to be that
#relative_path_from
in those Rubies doesn't work with strings:https://github.com/rake-compiler/rake-compiler/blob/77d9294a203a11b39ee2e3d295e91706049b91ea/lib/rake/extensiontask.rb#L166
...I believe the fix would be to change it to:
I can submit a PR if that helps!