rakelkar / gonetsh

GO wrapper for the windows NETSH tool
Apache License 2.0
11 stars 11 forks source link

Is the project still maintained? #13

Closed antoninbas closed 3 years ago

antoninbas commented 3 years ago

Hi - I wanted to check if the project is still maintained. If yes, would you be open to a PR with the following changes?

Additionally, would you be willing to make a Github release/ create a tag after making the changes above?

Thanks

rakelkar commented 3 years ago

Sure happy to help with this!

On Wed, Jan 27, 2021, 7:46 PM Antonin Bas notifications@github.com wrote:

Hi - I wanted to check if the project is still maintained. If yes, would you be open to a PR with the following changes?

  • switch from vendoring dependencies to using Go modules
  • replace the current go-powershell dependency with https://github.com/antoninbas/go-powershell. This fork converts the project to Go modules and removes the dependency on juju packages (which are distributed under an LGPL v3 license, making usage in commercial products difficult)

Additionally, would you be willing to make a Github release/ create a tag after making the changes above?

Thanks

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rakelkar/gonetsh/issues/13, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2CTBJ43CVDFDO5ZKDQJRDS4DMZZANCNFSM4WWLVE6Q .

antoninbas commented 3 years ago

@rakelkar Thanks for merging #14. Do you think you could create a Github release tag?

rakelkar commented 3 years ago

https://github.com/rakelkar/gonetsh/releases/tag/v0.3.2 works?

antoninbas commented 3 years ago

Works for me, but why not start at v0.1.0 or something similar?