Switch to Go modules - Githubissues

rakelkar / gonetsh

GO wrapper for the windows NETSH tool

Apache License 2.0

11 stars 11 forks source link

Switch to Go modules #14

Closed antoninbas closed 3 years ago

antoninbas commented 3 years ago

Switch to Go modules and remove vendoring
Use different fork of go-powershell: replace the current go-powershell dependency with https://github.com/antoninbas/go-powershell. This fork converts the project to Go modules and removes the dependency on juju packages (which are distributed under an LGPL v3 license, making usage in commercial products difficult)
Enable CI: run unit tests using Github workflows

Fixes #13

antoninbas commented 3 years ago

@rakelkar could you enable Github actions in this repo so the tests can run?

rakelkar commented 3 years ago

Hey Antonio - thanks for your PR - quick qn, did you try to get your changes in go-powershell updated to benmoss repo?

antoninbas commented 3 years ago

@rakelkar I wasn't planning on doing it, since benmoss/go-powershell is already a fork and the original project seems to be unmaintained. Is that an issue for you? If yes, I can try to reach out to benmoss.

rakelkar commented 3 years ago

Would be great if you can try to get an okay from benmoss him as a curtsy :)

rakelkar commented 3 years ago

have enabled actions btw!

antoninbas commented 3 years ago

I have opened the PR: https://github.com/benmoss/go-powershell/pull/1

If it's accepted, I'll update this PR. Looks like there are some unit tests failures, so I'll address them as well at that time.

antoninbas commented 3 years ago

I got my answer: https://github.com/benmoss/go-powershell/pull/1#issuecomment-774105035. He recommends switching to a different fork.

antoninbas commented 3 years ago

@rakelkar I rebased the PR and fix the test failures.

By the way, do you have any insight about the difference between this package and the upstream K8s one: https://github.com/kubernetes/kubernetes/tree/master/pkg/util/netsh?

antoninbas commented 3 years ago

@rakelkar I rebased the PR and fix the test failures.

By the way, do you have any insight about the difference between this package and the upstream K8s one: https://github.com/kubernetes/kubernetes/tree/master/pkg/util/netsh?

Actually there is no equivalent to https://github.com/rakelkar/gonetsh/tree/master/netroute in upstream K8s

antoninbas commented 3 years ago

@rakelkar friendly ping for this