search

rakeshkchhabra / AndroidApplications

0 stars 0 forks source link

Twitter App V2.0 #4

Open rakeshkchhabra opened 9 years ago

rakeshkchhabra commented 9 years ago

Please review Twitter client app https://github.com/rakeshkchhabra/AndroidApplications/tree/master/TwitterApp

/cc /cc @codepathreview @codepath

codepathreview commented 9 years ago

:+1: Project looks good. Good work on implementing so many optionals and working on UI enhancements. One of the key learning part of this assignment was how to architect your fragments so that reusable functionalities are abstracted out in a parent class and child classes have minimum responsibilities to handle. I did not see that in your code, it will be a good thing to try out later.

I have provided a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr, using the same patterns.