rakheshr / ios-training

0 stars 0 forks source link

Twitter App #4

Open rakheshr opened 10 years ago

rakheshr commented 10 years ago

Hi Tim (@timothy1ee)

Please review and let me know your feedback.

Thanks, Rakhesh

rakheshr commented 10 years ago

Hi Tim (@timothy1ee)

Forgot to mention, I have used a copy of your app and not the forked repository. So please review the one in.

Thanks, Rakhesh

timothy1ee commented 10 years ago

Good job! The point of this homework was to explore some challenges involved in developing a richer MVC client. Below is the checklist I went through when reviewing your application.

rakheshr commented 10 years ago

Thanks Tim

Thanks, Rakhesh

On Jan 28, 2014, at 11:07 AM, Timothy Lee notifications@github.com wrote:

Good job! The point of this homework was to explore some challenges involved in developing a richer MVC client. Below is the checklist I went through when reviewing your application.

Did you create a custom Tweet cell and properly set up Auto Layout constraints? Did you augment the User and Tweet model with the required properties? Does tapping on a Tweet take you to a detailed Tweet view? Is the detailed Tweet view styled like the mock? Did you add both standard and retina (@2x) image assets? A new feature of XCode is to use the Images.xcassets, it makes it easier to handle the standard and retina assets. If you only included standard assets, it will be scaled for retina displays which makes them a little blurry. Does tapping on retweet and favorite incremement the retweet and favorite count? If I go back to the index and tap on the same tweet again, is the tweet still marked as retweeted or favorited with the correct count? Does the compose view restrict the number of Twitter characters? — Reply to this email directly or view it on GitHub.