search

rakhi2104 / find-my-chicken

A React Web Application that tracks user's location using IP address from the source of request.
MIT License
4 stars 5 forks source link

F/dinamic ip #7

Closed scsjonatan closed 6 years ago

scsjonatan commented 6 years ago
scsjonatan commented 6 years ago

Is really necessary use that server? Or you asking for remove it?

rakhi2104 commented 6 years ago

If we already have an API to get the Location, why write again ? I'll definitely check your proposal too.

scsjonatan commented 6 years ago

Because is useless for localhost, if someone try to use the app locally it doesn't works.

Or Im not seeing anything? Hows the app supposed to be if you are using it on localhost?

sakethramanujam commented 6 years ago

The app will be moved to production/a potential usable js server online, once we setup all the dependencies in dev stage.

scsjonatan commented 6 years ago

That's ok, but doesn't answer my question How's the app supposed to be if you are using it on localhost?

Showing a localhost error or hardcoding 8.8.8.8 IP?

Dgiulian commented 6 years ago

I've created a PR that moves the query to the IPAPI to the server, so this eliminates the need to make the request from the browser.

scsjonatan commented 6 years ago

@Dgiulian Perfect, im check your PR and its great. Im gonna close this PR and send a PR with little changes