search

rakhimov / scram

Probabilistic Risk Analysis Tool (fault tree analysis, event tree analysis, etc.)
https://scram-pra.org
GNU General Public License v3.0
131 stars 54 forks source link

Tests failed on i686 system #262

Closed Vascom closed 6 years ago

Vascom commented 6 years ago

I am try update scram package for Fedora Linux. It seems good and all tests passed on all platforms except i686.

ExpressionTest.PeriodicTest11
-------------------------------------------------------------------------------
/builddir/build/BUILD/scram-0.16.2/tests/expression_tests.cc:269
...............................................................................
/builddir/build/BUILD/scram-0.16.2/tests/expression_tests.cc:297: FAILED:
  CHECK( dev->value() == 1 )
with expansion:
  1.0 == 1
PDAG

Full build and test log https://kojipkgs.fedoraproject.org//work/tasks/6635/25156635/build.log

On x86_64 all OK https://kojipkgs.fedoraproject.org//work/tasks/6631/25156631/build.log

Please help solve this problem.

rakhimov commented 6 years ago

Thanks again for adopting the package.

Hmm, I am surprised it is running w/ Catch 1.10.

My worst fear is that there's numeric instability on 32 bit platforms. I actually do not have 32bit platform setup for (continuous) tests right now. I will try to debug this problem on vm.

P.S. The dependencies on the scram.spec are a bit inaccurate. (should be: libxml2 instead of libxml++, boost >= 1.61, cmake >= 3.8)

Vascom commented 6 years ago

OK. I will wait. Versions of dependencies corrected.