search

rakhimov / scram

Probabilistic Risk Analysis Tool (fault tree analysis, event tree analysis, etc.)
https://scram-pra.org
GNU General Public License v3.0
131 stars 54 forks source link

GUI: Orphaned gates after an ancestor-gate's formula & type manipulations #279

Open bavovanachte opened 5 years ago

bavovanachte commented 5 years ago

I've had an issue a couple of times where I accidentally orphaned some events (or subtrees). The tool happily allowed me to save the file, but then when I tried to reopen it, the tool refused to do so claiming that there were multiple top events.

I managed to fix these issues by manually fiddling in the xml until it worked, but the situation shouldn't occur (or the tool should allow the user to fix it in the gui itself)

rakhimov commented 5 years ago

@bavovanachte Are you using the dev version or the master? The dev GUI hasn't yet been updated with the add-remove API.

rakhimov commented 5 years ago

Could you provide exact steps that led to orphaned gates?

rakhimov commented 5 years ago

Note this issue will become irrelevant if #209 is done first.

rakhimov commented 5 years ago

I think I missed this in the original implementation, so it is present in the master branch as well. Some cases of orphaned gates:

bavovanachte commented 5 years ago

Sorry for the delay. I'm using the version installed from apt now (0.16.2).

Would you like me to retest with a version on master?

bavovanachte commented 5 years ago

Will try to reproduce the issue later today, and provide a minimal example to reproduce

rakhimov commented 5 years ago

Sorry for the delay. I'm using the version installed from apt now (0.16.2).

Would you like me to retest with a version on master?

No need @bavovanachte . I confirmed the bug (or missing feature?) in all GUI releases. This is a design issue that needs to be properly solved by #209. I'd appreciate your tests once the feature is implemented. Thanks.