search

rakibdev / material-code

Material You | Dynamic theme for Visual Studio Code.
https://marketplace.visualstudio.com/items?itemName=rakib13332.material-code
17 stars 0 forks source link

Remove styles command not working on Windows. #2

Closed ackzell closed 2 years ago

ackzell commented 2 years ago

Hi,

Thanks for sharing your work @rakibdev !

Unfortunately I was not able to use your "remove styles" command and all my themes were stuck with the rounded styled tabs and buttons with the ripple effect on the clickable items.

I had to go into my Windows installation folder for VSCode and manually remove the code this extension adds to:

 C:\Users\{userName}\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\code\electron-browser\workbench\workbench.html

I don't know if this is a regular practice for extensions to update those files but being honest I don't feel right with the approach.

In any case this is the only way I was able to solve it and VSCode still complained that my installation was corrupted.

RicardoMoraisPOR commented 2 years ago

+1

rakibdev commented 2 years ago

@ackzell Hi, I checked in both Windows, Ubuntu. Unable to reproduce this issue. Error logs should show in Visual Studio Code DevTools. Can I get those?

I don't feel right with the approach

This is only way I find. This method used by popular "Custom CSS and JS loader" and "Synthwave" extension. Therefore, kept it optional. I will add in README "This modifies installation workbench.html file. And workbench.html resets after each update."

still complained that my installation was corrupted

Checksums in product.json also have to be updated using "Fix VSCode Checksums" extension if manually editing workbench.html

ackzell commented 2 years ago

Thanks for getting back at me @rakibdev

I uninstalled the theme and haven't added it back since.

Adding the note to the README seems like a good move. Thanks for the links!