rakr / vim-one

Adaptation of one-light and one-dark colorschemes for Vim
MIT License
1.98k stars 196 forks source link

Revert / Modify PR #104 #121

Closed lygamac closed 3 years ago

lygamac commented 3 years ago

The solution in PR #104 is not a viable solution for all users (there might be users using dark terminal with light colorscheme or vice-versa, or a different theme with makes the color incoherent.)

Suggestion, add:

if (&background == dark)
    " dark theme color codes
elseif (&background == light)
    " light theme color codes
endif 

The only drawback of this is to reload the plugin in order to perform an if check if the user switches the background.

lygamac commented 3 years ago

Solved by #120