search

rakr / vim-one

Adaptation of one-light and one-dark colorschemes for Vim
MIT License
1.99k stars 196 forks source link

Underline on nerdtree/file browser #39

Open aaronmoodie opened 7 years ago

aaronmoodie commented 7 years ago

Not sure if this is meant to be here, but there's an underline on NerdTree or when browsing files.

image

rakr commented 7 years ago

Hi Aaron,

This is definitely not meant to be there, here is how it should look like in NERDTree.

__d___h_p_s_01

Do you mind sharing your configuration: Vim or Neovim version, terminal, ...

Thanks

aaronmoodie commented 7 years ago

Hey Ramzi,

I'm on iTerm2 (v 3.0.14) and vim 7.4.1831. my vimrc is up on GH here https://github.com/aaronmoodie/vimdotfile/blob/master/vimrc

Thanks, Aaron

On Mon, Feb 27, 2017 at 12:19 PM Ramzi Akremi notifications@github.com wrote:

Hi Aaron,

This is definitely not meant to be there, here is how it should look like in NERDTree.

[image: __d___h_p_s_01] https://cloud.githubusercontent.com/assets/110558/23345726/e86b501c-fce6-11e6-8f02-d2f14461da36.png

Do you mind sharing your configuration: Vim or Neovim version, terminal, ...

Thanks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rakr/vim-one/issues/39#issuecomment-282606092, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGaRnq51vkBGRXP1nDxlScfwpsQF-Svks5rgiSZgaJpZM4MMWQe .

rakr commented 7 years ago

Hi Aaron, it's actually your version of Vim, I remember having this issue with version 7. This issues does not exist with Vim 8. I'm planning to fix this, this require some conditionals in the code that I need to wrap my mind around.

aaronmoodie commented 7 years ago

Hey Ramzi, right good to know! Makes it an easy fix from my end. thanks! On Tue, 28 Feb 2017 at 6:44 pm, Ramzi Akremi notifications@github.com wrote:

Hi Aaron, it's actually your version of Vim, I remember having this issue with version 7. This issues does not exist with Vim 8. I'm planning to fix this, this require some conditionals in the code that I need to wrap my mind around.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rakr/vim-one/issues/39#issuecomment-282966301, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGaRjgopEhZ2ksK7wZ9jimzTgvdJmxLks5rg9BZgaJpZM4MMWQe .

lkoning commented 4 years ago

On my Neovim I don't see any highlight line at all in NerdTree. nerdtree_underline

Really not sure if it's my init.vim. It's quite clean.

laurens@lakolap ~> nvim --version NVIM v0.4.3 Build type: Release LuaJIT 2.0.5 Compilation: /usr/bin/cc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -O2 -DNDEBUG -DMIN_LOG_LEVEL=3 -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fdiagnostics-color=always -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -I/build/neovim/src/build/config -I/build/neovim/src/neovim-0.4.3/src -I/usr/include -I/build/neovim/src/build/src/nvim/auto -I/build/neovim/src/build/include Compiled by builduser