search

rakr / vim-one

Adaptation of one-light and one-dark colorschemes for Vim
MIT License
1.99k stars 196 forks source link

Showing confusing matching #47

Closed taq closed 7 years ago

taq commented 7 years ago

I'm facing an weird situation here. If I use the colorscheme, and have some code like

if (var == 1) {
}

When I'm on the first (, it shows ) using bold, with black over red. When I'm on {, it shows the } using bold, with black over red. So it makes me feels that I'm on the end char when I'm on the start! Don't know if there are some configuration for that, but on other themes it works ok.

rakr commented 7 years ago

Does this look like what you are experiencing?

1__accueil__nvim_test_c__nvim_ 1__accueil__nvim_test_c__nvim_

with a dark background:

1__accueil__nvim_test_c__nvim_ 1__accueil__nvim_test_c__nvim_
taq commented 7 years ago

Yeah! As I'm using the dark background, the cursor on the match is black with a red background, so it looks like it's the cursor there. On your first dark example, under the cursor it will be no difference but on the match it will be a black ) char over a red background.

one

taq commented 7 years ago

Forgot to say, this behavior is just on the one theme, the onedark works ok.

rakr commented 7 years ago

can you try the following command and let me know if something changes:

:call one#highlight('MatchParen', 'e06c75', '', '')

Also, if you can provide more information on your setup:

taq commented 7 years ago

Just got a E117: function unknown. But the code is there:

colors/one.vim:  function! one#highlight(group, fg, bg, attr)
rakr commented 7 years ago

Oh, it seems that you are running an old version, do you mind updating the colorscheme

taq commented 7 years ago

Weird, the last commit on the repo (I installed it using Vundle) seems updated:

commit 2fe00fc767f001984755886d6edf056029f1d946
Merge: 9b5defa 14d7b12
Author: Ramzi Akremi <ramzi.dev@icloud.com>
Date:   Thu May 4 18:19:45 2017 +1000

    Merge pull request #46 from nguquen/master

    Define color for Neovim 0.2.0: `Whitespace` highlight group

Just run :PluginUpdate now and no changes found. :-(

taq commented 7 years ago

I'll remove it and install it again.

taq commented 7 years ago

Jesus Mary Joseph. Just found a pre-plugin version of one on my colors directory! :-p

rakr commented 7 years ago

Thanks, I was going to curse as well!

taq commented 7 years ago

Dude, shame on me! Sorry! It was the old version. :-( Now is working ok!