search

rakr / vim-one

Adaptation of one-light and one-dark colorschemes for Vim
MIT License
1.99k stars 196 forks source link

Add VertSplit border; Clear Folded background #58

Closed ashfinal closed 3 years ago

ashfinal commented 7 years ago

rakr commented 7 years ago

Hi, thanks for submitting this PR, and sorry for the delay, I took a month off (completely disconnecting from the Internet).

I am not sure if I would merge the PR as it is really a matter of taste, I wanted the splits to be as subtle as possible hence just the use of the foreground attribute.

One has now a "public API" that allow user to tweak the colorscheme to their taste/needs, I would suggest you give it a try.

This PR makes me think that an 'alternate' version can be developed, people would toggle a variable and depending on the value would apply specific settings.

These variables/values would be along the lines of "one-subtle", "one-bold", ...

If my suggestion above does not fly, do you mind opening an issue for this?

ashfinal commented 7 years ago

Thanks for your reply. I've create an issue to explain why this PR is necessary.

Dbz commented 7 years ago

@ashfinal would you be able to post how to do this using the public API? I'd also like to change these attributes, but I am very new to vim. Thank you for any help you can provide!

ashfinal commented 7 years ago

@Dbz Sorry for the late reply.

As here instructs: call one#highlight('vimLineComment', 'cccccc', '', 'none'). All you need to do is add some lines like this in your vimrc file.

But I guess your problem may lay which "color group" I should highlight? Where does the vimLineComment come from?

Well, this script will help you out. Copy this paragraph into your vimrc, and restart Vim. Then you can know the group and color under your cursor.

wsdjeg commented 6 years ago

why remove fold background？ It will be hard for user to find the fold.