rakr / vim-one

Adaptation of one-light and one-dark colorschemes for Vim
MIT License
1.99k stars 196 forks source link

Maybe need some improvement on VertSplit and Folded background? #61

Open ashfinal opened 7 years ago

ashfinal commented 7 years ago

Thanks for your wonderful colorscheme, I've made it the default one to my vimrc configuration. 👍 Good job!

Still I found one or two places which could be improved (at least in my opinion). i.e. VertSplit and Folded background. As far as I see, Folded background is not necessary. Long ————————— differs it from other contents, explicitly telling users it is a folded block. VertSplit background actually doesn't help, just makes this colorscheme not so attractive. As for VertSplit, the absence of bg color makes it different to tell which split is which. And sometimes I disable linenumber display, which simply crowds all splits together and makes things worse.

I've create a PR for this at here #58 . Please try it out and decide to merge or not by yourself.