rakr / vim-two-firewatch

A blend between duotone light and firewatch for atom
462 stars 42 forks source link

Theme loads with errors #1

Closed peteyycz closed 8 years ago

peteyycz commented 8 years ago

https://dl.dropboxusercontent.com/1/view/5eeo8ycydhe1n6c/Apps/Shutter/Selection_005.png

By default it does not load the theme when I try to load twofirewatch theme. When I source my vimrc it gives me errors and hangs the terminal for a while but the colors get fixed.

My vimrc looks like the following: https://github.com/peteyy/dotfiles/blob/master/config/nvim/init.vim#L346

rakr commented 8 years ago

Hi @peteyy you seem to run an older version that had the bug. Your init.vim seems to be correct. Seeing that you are also using Plug, do you mind running the command PlugUpdate to get the last version?

Make sure you exit and reload Neovim.

peteyycz commented 8 years ago

I updated the plugins but according to the changelog I was running the latest two-firewatch. Could this be linux related?

rakr commented 8 years ago

Don't think so, I had the same problem when I added this airline theme on a Mac. To start on a clean slate, I suggest you remove the colorscheme folder from your Plugged folder and try to reinstall it again.

The colorscheme is working properly, the problem seem to be with the airline theme.

peteyycz commented 8 years ago

I tried to remove all the plugins from my bundle folder. It still makes no change in the airline theme by default, but after first sourcing it looks like this. https://dl.dropboxusercontent.com/1/view/m2zx5l7e8gokb2t/Apps/Shutter/Selection_006.png

After sourcing the second time it gives me the errors and then it works properly.

Also when I try to call refresh manually I get the following error:

Error detected while processing function airline#themes#twofirewatch#refresh:
line   19:
E121: Undefined variable: g:airline#themes#one#palette
E15: Invalid expression: g:airline#themes#one#palette.normal_modified
line   25:
E121: Undefined variable: g:airline#themes#one#palette
E15: Invalid expression: g:airline#themes#one#palette.normal_modified
line   31:
E121: Undefined variable: g:airline#themes#one#palette
E15: Invalid expression: g:airline#themes#one#palette.normal_modified
rakr commented 8 years ago

Weird, can you please check the content of the following file: bundle/vim-twofirewatch/autoload/airline/themes/twofirewatch.vim, it should not contain any reference to g:airline#themes#one but instead g:airline#themes#twofirewatch.

peteyycz commented 8 years ago

It has no reference to g:airline#themes#one all of them are twofirewatch

rakr commented 8 years ago

Got it, it's actually a bug, will be posting an update very soon.

rakr commented 8 years ago

Just pushed an update, run PlugUpdate and let me know

peteyycz commented 8 years ago

Airline works great now. Thanks for the fast response and fix, you're awesome!

I also noticed this issue: https://dl.dropboxusercontent.com/1/view/xbws1iq96xg1dts/Apps/Shutter/Selection_007.png

If I open up a file within a TMUX session the background of some text (comments mostly) change and make it harder to read. Should I file another issue with this?

rakr commented 8 years ago

No worries, thanks for documenting the issue. I've also noticed a change with tmux, can you please open a new issue and attach your screenshot directly yo it (instead of linking to a dropbox file :D )