raksha-life / rescuekerala

Website for coordinating rehabilitation of people affected in the Kerala Floods
https://keralarescue.in
MIT License
677 stars 575 forks source link

Fix 1033. Proper title tag #1039

Open muhammed-ajmal opened 5 years ago

muhammed-ajmal commented 5 years ago

Issue Reference

This PR addresses the Issue : Fixes #1033

Changes

I had updated the base.html template with {% block title %}{% endblock %} then extended it all other templates( html files)

Unfortunately, you can see there are many deletions of blank spaces, these changes are done by atom editor itself.

muhammed-ajmal commented 5 years ago

Do we need to add Malayalam version ?, I found google -translator already translating titles to Malayalam

sreenadh commented 5 years ago

Duplicate code

{% block title %}{% endblock %}Kerala Rescue

Change to

{% block title %}{% endblock %} - Kerala Rescue

And for individual pages, for eg Change {% block title %}Announcements&nbsp-&nbsp{% endblock %}

To

{% block title %}Announcements{% endblock %}

sreenadh commented 5 years ago

@Ajuajmal its better to pass title from controller so that we can use it directly in base.html for both breadcrumb's last tag and tag and add parents only in individual views. Or define a breadcrumb class to define breadcrumbs in a centralized location and simply call the method in respective views along with title.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/subins2000"><img src="https://avatars.githubusercontent.com/u/2305675?v=4" />subins2000</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>@Ajuajmal can you please fix the conflicts ?</p> <p>Also, my PR #1054 adds a permalink to announcements. Can the page have a meta description and proper title so that the announcement can be shared via whatsapp/social media with proper previews ? This'll solve #1057 </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/sreenadh"><img src="https://avatars.githubusercontent.com/u/89586?v=4" />sreenadh</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>@Ajuajmal please fix the merge conflicts.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>