search

raksha-life / rescuekerala

Website for coordinating rehabilitation of people affected in the Kerala Floods
https://keralarescue.in
MIT License
674 stars 575 forks source link

Add permalinks for announcements #1054

Closed subins2000 closed 5 years ago

subins2000 commented 5 years ago

Issue Reference

This PR addresses the Issue : Fixes #1017

Summarize

Add permalinks for announcements

Sample URL : https://keralarescue.in/announcements/2 https://keralarescue.in/announcements/4

sreenadh commented 5 years ago

Why not a separate view file like announcement-view.html or announcements/view.html ?

subins2000 commented 5 years ago

@sreenadh Because it's easier to manage the announcement card view in one page itself.

There's an additional proposal to add sharing buttons too.

sreenadh commented 5 years ago

Share buttons can be put in separate view file and include both in both views. In future we might need more feature separately for view and announcements then announcements.html will get bloated with if else conditions.

subins2000 commented 5 years ago

@sreenadh you're right. This was just a quick hack. In case there is more differences between the two, it should be separated.

dauntlessnomad commented 5 years ago

fix the conflicts please

subins2000 commented 5 years ago

@tomahawk-pilot done