search

rakshasa / libtorrent

libTorrent BitTorrent library
http://rtorrent.net/downloads/
GNU General Public License v2.0
886 stars 209 forks source link

BEP7 remove IPv4 escaping #139

Closed anthonyryan1 closed 7 years ago

anthonyryan1 commented 7 years ago

Fix for regression introduced in d0b7724febec620c43babf08fcb5a6f4148af01c

While some trackers automatically handle decoding encoded URL attributes others (primarily for performance reasons) stick very close to the spec.

When implementing the &ipv4= parameter I mistakenly added encoding for symbols to IPv4 when BEP7 only specified that that should be the case for IPv6. IPv4 is meant to be sent without encoding according to BEP7 and other client behaviour.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 18.017% when pulling 267be8e2a6ac200ebc180341bd18fa3f9fc45eda on anthonyryan1:master into c3c74f82424d80b7807664aa8b11f86da8b56ab1 on rakshasa:master.