Fix compilation issue with gcc v6.x and empty CXXFLAGS

rakshasa / libtorrent

libTorrent BitTorrent library

http://rtorrent.net/downloads/

GNU General Public License v2.0

885 stars 209 forks source link

Fix compilation issue with gcc v6.x and empty CXXFLAGS #156

Closed chros73 closed 6 years ago

chros73 commented 7 years ago

Fix compilation issue with gcc v6.x and empty CXXFLAGS:

it removes -O2 flag and compilation can fail (e.g. with make -j4)

Note: CFLAGS are also effected.

Closes: #155 Refers to: https://github.com/rakshasa/rtorrent/pull/628

Edit: I have updated the fix:

let the building environment (autotools) define what flags are used only if CFLAGS/CXXFLAGS is empty

coveralls commented 7 years ago

Coverage decreased (-0.02%) to 18.02% when pulling c2b119de0e66fb047bb20e445ac8e25824448858 on chros73:fix_cxxflags_check into c167c5a9e0bcf0df23ae5efd91396aae0e37eb87 on rakshasa:master.

coveralls commented 7 years ago

Coverage increased (+0.003%) to 18.043% when pulling 8229218dff1105e9fb2bb2c7510910a0db98f3ef on chros73:fix_cxxflags_check into c167c5a9e0bcf0df23ae5efd91396aae0e37eb87 on rakshasa:master.