search

rakshasa / libtorrent

libTorrent BitTorrent library
http://rtorrent.net/downloads/
GNU General Public License v2.0
885 stars 209 forks source link

Increase piece length max #165

Closed adambarta closed 5 years ago

adambarta commented 6 years ago

Still within INT_MAX could go to 24 AFAIK

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.003%) to 18.043% when pulling 11c4d641d9bad198f8d1d4bceb6e402fbb42a9a2 on adambarta:master into c167c5a9e0bcf0df23ae5efd91396aae0e37eb87 on rakshasa:master.

rakshasa commented 6 years ago

The chunk size limit is there as a sanity check, 128mb chunks aren't sane. Are there really people out there using these sizes?

adambarta commented 6 years ago

Most trackers I have looked at will support even 512mb chunks. Say you have a TB torrent but want a reasonably sized .torrent file

On Mon, Jun 11, 2018 at 4:23 PM, Jari Sundell notifications@github.com wrote:

The chunk size limit is there as a sanity check, 128mb chunks aren't sane. Are there really people out there using these sizes?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rakshasa/libtorrent/pull/165#issuecomment-396261512, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_A69r8ND9ldkICaT2R4oMAc5oDHvTqks5t7n1vgaJpZM4STSUi .

-- Adam Barta c: +27 72 504 7098 e: adambarta@gmail.com

MarkRose commented 5 years ago

Here's a 2509 GB torrent that ends up having 40155 chunks because it's using only 64MB chunks. The torrent file is nearly 1MB.