rakshasa / libtorrent

libTorrent BitTorrent library
http://rtorrent.net/downloads/
GNU General Public License v2.0
885 stars 209 forks source link

Fix honoring interval of announce tracker request #168

Closed chros73 closed 6 years ago

chros73 commented 6 years ago

Fix honoring interval of announce tracker request:

Fixes: #167, https://github.com/rakshasa/rtorrent/issues/386

The following unit tests are failing due to this change:

tracker_controller_features.cc:49:Assertion
Test name: tracker_controller_features::test_requesting_basic
assertion failed
- Expression: test_goto_next_timeout(&tracker_controller, tracker_0_0->min_inte
rval() - 30)

tracker_controller_features.cc:259:Assertion
Test name: tracker_controller_features::test_groups_requesting
assertion failed
- Expression: test_goto_next_timeout(&tracker_controller, tracker_0_0->min_inte
rval() - 30)

tracker_controller_requesting.cc:47:Assertion
Test name: tracker_controller_requesting::test_hammering_basic_success
assertion failed
- Expression: test_goto_next_timeout(&tracker_controller, tracker_0_0->min_inte
rval())

tracker_controller_requesting.cc:47:Assertion
Test name: tracker_controller_requesting::test_hammering_basic_success_long_timeout
assertion failed
- Expression: test_goto_next_timeout(&tracker_controller, tracker_0_0->min_inte
rval())

tracker_controller_requesting.cc:47:Assertion
Test name: tracker_controller_requesting::test_hammering_basic_success_short_timeout
assertion failed
- Expression: test_goto_next_timeout(&tracker_controller, tracker_0_0->min_inte
rval())

tracker_controller_requesting.cc:47:Assertion
Test name: tracker_controller_requesting::test_hammering_basic_failure
assertion failed
- Expression: test_goto_next_timeout(&tracker_controller, tracker_0_0->min_inte
rval())

tracker_controller_requesting.cc:47:Assertion
Test name: tracker_controller_requesting::test_hammering_basic_failure_long_timeout
assertion failed
- Expression: test_goto_next_timeout(&tracker_controller, tracker_0_0->min_inte
rval())

tracker_controller_requesting.cc:47:Assertion
Test name: tracker_controller_requesting::test_hammering_basic_failure_short_timeout
assertion failed
- Expression: test_goto_next_timeout(&tracker_controller, tracker_0_0->min_inte
rval())

tracker_controller_requesting.cc:145:Assertion
Test name: tracker_controller_requesting::test_hammering_multi_success
assertion failed
- Expression: test_goto_next_timeout(&tracker_controller, next_tracker->min_int
erval() - 30)

tracker_controller_requesting.cc:142:Assertion
Test name: tracker_controller_requesting::test_hammering_multi_success_long_timeout
assertion failed
- Expression: test_goto_next_timeout(&tracker_controller, next_tracker->min_int
erval() - 30)

tracker_controller_requesting.cc:136:Assertion
Test name: tracker_controller_requesting::test_hammering_multi_success_short_timeout
assertion failed
- Expression: test_goto_next_timeout(&tracker_controller, next_tracker->min_int
erval() - 30)

tracker_timeout_test.cc:141:Assertion
Test name: tracker_timeout_test::test_timeout_requesting
assertion failed
- Expression: torrent::tracker_next_timeout(&tracker, flags) == 600