Open montoner0 opened 5 years ago
warning message: (new, optional) Similar to failure reason, but the response still gets processed normally. The warning message is shown just like an error.
I don't think it would be correct to fail the tracker reply based on words in the warning message, it should instead have a way of both processing the reply and displaying the message in the client.
Agree, it would be nice to have some more flexible solution. But for know, as a quick hack it should be enough. Or it would be better to register this as an issue?
I'm guessing the one of the reasons tracker admins were even using warning message
instead of failure message
was to work around rTorrent's behavior of ignoring intervals on properly-bencoded tracker failures. Merging this would mean it would go back to the "announce every 300 seconds" pattern, instead of the 3030
being requested in the response you posted. I've opened a PR here to tell libtorrent to respect min interval
here https://github.com/rakshasa/libtorrent/pull/246, but even with that fix, I'm not sure it's worth playing whack-a-mole in terms of which keys are error codes and which aren't.
Some trackers send "warning message" instead of a failure when a torrent is not registered on the tracker. Looks like this:
The change will turn this warning into an error.