rakshasa / libtorrent

libTorrent BitTorrent library
http://rtorrent.net/downloads/
GNU General Public License v2.0
883 stars 210 forks source link

libtorrent: FTBFS on hurd-i386: error: 'IPV6_TCLASS' was not declared in this scope. #219

Closed hahawang-github closed 3 years ago

hahawang-github commented 3 years ago

I decide to fix a broken package found at the recommended page(https://people.debian.org/~sthibault/out_of_date.txt) named libtorrent.

After I downloaded the package source and tried to build without any modifications under the debian hurd running in qemu (debian-hurd-20210219.img), I got the following error.

   socket_fd.cc: In member function 'bool torrent::SocketFd::set_priority(torrent::SocketFd::priority_type)':
   socket_fd.cc:78:43: error: 'IPV6_TCLASS' was not declared in this scope; did you mean 'IPOPT_CLASS'?

To fix this bug, thanks to the help of people at debian-hurd & bug-hurd mailing list, I decide to block the usage of the IPV6_TCLASS when it is not defined.

A pull request is available.

The gnu hurd mailing list, that already contains a submitted patch and other people's reviews.

https://lists.gnu.org/archive/html/bug-hurd/2021-04/msg00080.html

rakshasa commented 3 years ago

Closing, see PR.