rakshasa / rtorrent

rTorrent BitTorrent client
https://github.com/rakshasa/rtorrent/wiki
GNU General Public License v2.0
4.05k stars 412 forks source link

Configure: --with-xmlrpc-c=PATH seems to be broken #1243

Open TurtleWilly opened 10 months ago

TurtleWilly commented 10 months ago

I do have xmlrpc-c in a custom path (not in any of the standard system include/lib paths), so I need to manually specify its location via configure. configure --help suggest that the --with-xmlrpc-c parameter supports giving the PATH as an argument. That doesn't seem to work and always comes out as Could not compile XMLRPC-C test.

In fact only using --with-xmlrpc-c=yes, and manually extending the PATH like this seemed to work for me:

export PATH=/usr/local/mystuff/xmlrpc-c/latest/bin:$PATH \
export PKG_CONFIG_PATH=/usr/local/mystuff/rtorrent/latest/lib/pkgconfig:/usr/local/mystuff/xmlrpc-c/latest/lib/pkgconfig:/usr/local/lib/pkgconfig
./configure \
    --prefix=/usr/local/mystuff/rtorrent/0.9.8 \
    --with-xmlrpc-c=yes \
    CPPFLAGS='-I/usr/local/mystuff/xmlrpc-c/latest/include' \
    LDFLAGS=' -L/usr/local/mystuff/xmlrpc-c/latest/lib'
kannibalox commented 9 months ago

It's definitely confusing, but it's meant to specify a path to the xmlrpc-c-config binary, which will allow the build process to automatically generate the correct CPPFLAGS and LDFLAGS. You can see this here: https://github.com/rakshasa/rtorrent/blob/master/scripts/checks.m4#L398