rakshasa / rtorrent

rTorrent BitTorrent client
https://github.com/rakshasa/rtorrent/wiki
GNU General Public License v2.0
4.2k stars 415 forks source link

Update tracker before delete the torrent #899

Open Feriman22 opened 5 years ago

Feriman22 commented 5 years ago

Hi,

I come from this thread. The author of ruTorrent sent me here.

I would like to set this below: One torrent reached the defined ratio target and the action is "Remove data (All)". The tracker is not received yet the latest uploaded data size (how much data I uploaded since last refresh), so I have to update tracker before the plugin delete the torrent.

I'm using the ratio plugin of ruTorrent.

Is it possible?

Thank you!

pyroscope commented 5 years ago

The author of ruTorrent sent me here.

Which is a cheap way avoiding an answer.

ruTorrent use rtorrent implementation of ratio system.

The actions called by the ratio rules are not written by rtorrent however, but by that plugin.

Novik commented 5 years ago

The actions called by the ratio rules

Plugin call combination d.stop/d.close/d.erase. AFAIK this must be enough for updation of corresponding trackers. In any case, AFAIR, rtorrent xmlrpc API doesn't provide commands for manual update of trackers. I.e. this is a problem of client.

chros73 commented 5 years ago

rtorrent xmlrpc API doesn't provide commands for manual update of trackers.

Not just that but this kind of behaviour should be included in the client itself. There's a similar issue when updating tracker is also needed when leeching a download has been finished. https://github.com/rakshasa/libtorrent/issues/191

I wouldn't await for a quick fix though, there are pending PRs that will modify the current behaviour of finishing downloading.

rakshasa commented 5 years ago

Yes, this is an issue with the client not guaranteeing the event is sent to the tracker afaics.

Not a priority as I'm redoing other parts, however PRs are welcome.

Feriman22 commented 5 years ago

Thank you all! I'm waiting for the fix.

chros73 commented 5 years ago

however PRs are welcome

If the rest of my patches will be merged then I'll probably take a quick look into this ;)