search

raku-community-modules / DBIish

Database interface for Raku
89 stars 31 forks source link

Add support: issues #203, #204, #207 #205

Closed ancientwizard closed 3 years ago

ancientwizard commented 3 years ago
ancientwizard commented 3 years ago

A vision for issues #203, #204

jonathanstowe commented 3 years ago

Hi, Thanks for this, but could you split it into multiple pull-requests as there are several different things in here which are subject to different conversations? As it stands it's an all or nothing merge so it's a bit difficult if people have different views on parts of it.

ancientwizard commented 3 years ago

I'm glad you brought that up. I wanted to compare notes because I found the behavior of a pull to be different than I expected.

A little history; in the past I've, cloned (GH->GH), clone to my dev box, made change, commit, push and then send a pull request; stop. Never any issue with pull requests as far as 1, 2 or 3 etc.

In this case I used the same model, clone (GH->GH), clone to Linux-VM, made change, commit, push(GH), pull-request. But the fun didn't stop there; As you know I proceeded to make change, commit, and push; I only made the one pull-request and apparently as long as I continue to make change and push to my clone it will magically show up in that request. I think that makes sense, the change is in my clone not the request.

Best guess you must control the change you accept when the pull is performed. However; I see on this pull-request a check-box that is checked and says "Allow edits by maintainers".

The help (?) with that button says "If checked, users with write access to raku-community-modules/DBIish can add new commits to your master branch. You can always change this setting later." So it seems you can make change to my clone until your are satisfied and then perform the pull. Sweet!

MasterDuke17 commented 3 years ago

In this case I used the same model, clone (GH->GH), clone to Linux-VM, made change, commit, push(GH), pull-request. But the fun didn't stop there; As you know I proceeded to make change, commit, and push; I only made the one pull-request and apparently as long as I continue to make change and push to my clone it will magically show up in that request. I think that makes sense, the change is in my clone not the request.

The solution to this is to create a branch for each distinct change, and then create a pull request from that branch on your clone to master of the original.

ancientwizard commented 3 years ago

I was thinking the same thing; So I guess the question is how shall I break this up? #203 & #204 go hand in hand, agree one branch for that and another for #207? For the moment I'm not committed to making any more work for myself; I.E. making branches etc, until I'm sure there is interest in pulling it.