raku-community-modules / Linenoise

Linenoise bindings for Raku
MIT License
15 stars 6 forks source link

can't install Linenoise on Windows #29

Open Prince213 opened 4 years ago

Prince213 commented 4 years ago

Hi, I'm trying to install Linenoise with zef, and got a warning similar with #25:

zef install Linenoise
===> Searching for: Linenoise
===> Updating cpan mirror: https://raw.githubusercontent.com/ugexe/Perl6-ecosystems/master/cpan1.json
===> Updating p6c mirror: https://raw.githubusercontent.com/ugexe/Perl6-ecosystems/master/p6c1.json
===> Updated p6c mirror: https://raw.githubusercontent.com/ugexe/Perl6-ecosystems/master/p6c1.json
===> Updated cpan mirror: https://raw.githubusercontent.com/ugexe/Perl6-ecosystems/master/cpan1.json
===> Searching for missing dependencies: LibraryMake
===> Searching for missing dependencies: Shell::Command
===> Searching for missing dependencies: File::Which, File::Find
===> Building: Linenoise:ver<0.1.1>:auth<Rob Hoelz>
===> Building [OK] for Linenoise:ver<0.1.1>:auth<Rob Hoelz>
===> Testing: File::Which:ver<1.0.1>
[File::Which] # Found perl6 at 'D:\perl\bin\perl6.EXE'
[File::Which] # Found perl6 at 'D:\perl\bin\perl6.EXE' using whence     
===> Testing [OK] for File::Which:ver<1.0.1>
===> Testing: File::Find:ver<0.1>
===> Testing [OK] for File::Find:ver<0.1>
===> Testing: Shell::Command
===> Testing [OK] for Shell::Command
===> Testing: LibraryMake:ver<1.0.0>:auth<github:retupmoca>
===> Testing [OK] for LibraryMake:ver<1.0.0>:auth<github:retupmoca>     
===> Testing: Linenoise:ver<0.1.1>:auth<Rob Hoelz>
===> Testing [OK] for Linenoise:ver<0.1.1>:auth<Rob Hoelz>
===> Installing: File::Which:ver<1.0.1>
===> Installing: File::Find:ver<0.1>
===> Installing: Shell::Command
===> Installing: LibraryMake:ver<1.0.0>:auth<github:retupmoca>
===> Installing: Linenoise:ver<0.1.1>:auth<Rob Hoelz>
Use of Nil in string context
  in block  at site#sources\0BDF8C54D33921FEA066491D8D13C96A7CB144B9 (Linenoise) line 15

When I run REPL, this warning is emitted:

I ran into a problem while trying to set up Linenoise: Must specify something as a path: did you mean '.' for the current directory?
Continuing without tab completions or line editor
You may want to consider using rlwrap for simple line editor functionality

To exit type 'exit' or '^Z'
>

Environment: zef version: v0.8.2 Rakudo version:

This is Rakudo version 2019.07.1-478-g75056dfa1 built on MoarVM version 
2019.07.1-309-g48491b896
implementing Perl 6.d.
hoelzro commented 4 years ago

Hello,

I've stopped working on this library - I recommend reaching out to the fine folks at #raku on IRC and seeing if they can help you out!

JJ commented 4 years ago

If that's the case, maybe you can give someone else privileges to keep working on this? This is still part of Rakudo Star (until, probably, next release)

hoelzro commented 4 years ago

@JJ Sure, I'd be happy to! How do you feel about me transfering ownership to the perl6 organization?

Prince213 commented 4 years ago

@hoelzro It will be great if this library continues to be maintained as Readline is too big for command line editing and requires a lot of efforts to make it work on Windows.

JJ commented 4 years ago

@hoelzro if there's not anyone else wanting to co-maintain it, we could transfer it to perl6-community-modules

Prince213 commented 4 years ago

@JJ Good idea. It's really important for editing experience.

hoelzro commented 4 years ago

Sounds good - consider it done!

hoelzro commented 4 years ago

Ok...I tried, but GitHub tells me I lack the permissions to create public repositories on perl6-community-modules =/

Prince213 commented 4 years ago

@hoelzro I guess you need be a member of perl6-community-modules first. Maybe you should connect someone in perl6-community-modules.

JJ commented 4 years ago

We need to do it by hand, I think. No problem, once I have your permission.

El dom., 17 nov. 2019 14:20, Rob Hoelz notifications@github.com escribió:

Ok...I tried, but GitHub tells me I lack the permissions to create public repositories on perl6-community-modules =/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hoelzro/p6-linenoise/issues/29?email_source=notifications&email_token=AAAAD5GASYEOBT6B4PQVOWTQUFAIXA5CNFSM4JOEXG42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEILZDQ#issuecomment-554744974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAD5AWFVFHTMC4W5ZDID3QUFAIXANCNFSM4JOEXG4Q .

hoelzro commented 4 years ago

@JJ Sounds good - do I just add you as a co-maintainer, then?

JJ commented 4 years ago

I think that might be a better option than just moving it... I don't know much about Windows, but I guess I could have a go at the other issues. Thanks!

El dom., 17 nov. 2019 a las 19:58, Rob Hoelz (notifications@github.com) escribió:

@JJ https://github.com/JJ Sounds good - do I just add you as a co-maintainer, then?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hoelzro/p6-linenoise/issues/29?email_source=notifications&email_token=AAAAD5DJVRFBB6RSVUDLS6TQUGH55A5CNFSM4JOEXG42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEITFVI#issuecomment-554775253, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAD5G65HWAQSTSLOP5GK3QUGH55ANCNFSM4JOEXG4Q .

-- JJ

hoelzro commented 4 years ago

@JJ Ok, you should have an invite to be a collaborator now. I'd prefer if the repo were moved under the perl6 umbrella, just so there's no confusion about my ability to contribute fixes in the future!

JJ commented 4 years ago

the problem is that we would lose the issues, we would need to re-release it, and it would be generally problematic. Let's give this a try and see if we can come up with a solution that gets it back into Rakudo Star; I'll try to get some more people to help too and might ask you to add them to the repo. The problem is that moving it to the perl6-community-modules repos does not guarantee anyone adopting them, only that more people (those with privs) have the capability to do it... But in some cases, everyone is able, no one is responsible... This might mean that you will still get notifications of activity and so on, but I would really prefer you to stay around just in case we get into a tight knot...

And, again, thanks!

JJ commented 4 years ago

This is line 15:

    my constant LIBLINENOISE = %?RESOURCES<libraries/linenoise>.Str;

I think it's simply failing to find the library in Windows. I guess this can be fixed with instructions, more than any other thing...

JJ commented 4 years ago

From here: https://github.com/antirez/linenoise/issues/113 it looks line the underlying linenoise library does not work in Windows, and has apparently never had. The issue selects several alternatives, mostly written in C++, which are also mentioned in this README.md. The problem is that I have no idea if the library itself is compatible; also, C++ and the Native interface are probably not a good mix... So I don't see an easy solution for this.

JJ commented 4 years ago

OK, so it might be fixable after all, according to #17. But you'll need to use mingw.

hoelzro commented 4 years ago

@JJ The linenoise code in this repo is actually from a MoarVM-based fork (see 72003ff) that supports Windows - I'm guessing the use of %?RESOURCES needs to change. You might find d0a2ec0a and f368fe0d useful to look at for ideas

JJ commented 4 years ago

Thanks!

El mar., 19 nov. 2019 a las 6:48, Rob Hoelz (notifications@github.com) escribió:

@JJ https://github.com/JJ The linenoise code in this repo is actually from a MoarVM-based fork (see 72003ff https://github.com/hoelzro/p6-linenoise/commit/72003ff8b1a783c27472ad663e593e3f50957524) that supports Windows - I'm guessing the use of %?RESOURCES needs to change. You might find d0a2ec0 https://github.com/hoelzro/p6-linenoise/commit/d0a2ec0ade6d9a4ecc1fd7d6b81ee305a5f9a3f1 and f368fe0 https://github.com/hoelzro/p6-linenoise/commit/f368fe0d6c31f05f69d9801c7c52b93ebec92eaa useful to look at for ideas

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hoelzro/p6-linenoise/issues/29?email_source=notifications&email_token=AAAAD5AMP4GIPKOIYCNH5TTQUN42XA5CNFSM4JOEXG42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEM6DQQ#issuecomment-555344322, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAD5CMWAVEFUXTWZZNUH3QUN42XANCNFSM4JOEXG4Q .

-- JJ